Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Mention ignore_changes_global_secondary_index can cause table to be recreated #83

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

mnylensc
Copy link
Contributor

@mnylensc mnylensc commented Feb 9, 2024

Description

Add a warning to the docs that setting ignore_changes_global_secondary_index after table is already created will cause the table to be recreated, and provide a migration path that doesn't result in data loss, similar to how was documented for enabling autoscaling for pre-existing table.

Closes #82

Motivation and Context

I feel that it's important to document cases where the resources maintained by the modules cause those resources to be recreated, as that can often come as a surprise and be only visible when reviewing the terraform plan output.

Breaking Changes

No

How Has This Been Tested?

N/A

@mnylensc mnylensc changed the title Docs: Mention ignore_changes_global_secondary_index can cause table to be recreated docs: Mention ignore_changes_global_secondary_index can cause table to be recreated Feb 9, 2024
@antonbabenko antonbabenko merged commit 6f55029 into terraform-aws-modules:master Feb 9, 2024
11 of 12 checks passed
@antonbabenko
Copy link
Member

This PR is included in version 4.0.1 🎉

Copy link

github-actions bot commented Apr 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for ignore_changes_global_secondary_index should warn that it will destroy the table
2 participants